[webkit-reviews] review granted: [Bug 208458] Web Inspector: Remove old raster icons for object types and resources : [Attachment 392165] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Jon Davis <jond at apple.com>'s
request for review:
Bug 208458: Web Inspector: Remove old raster icons for object types and
resources
https://bugs.webkit.org/show_bug.cgi?id=208458

Attachment 392165: Patch

https://bugs.webkit.org/attachment.cgi?id=392165&action=review




--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 392165
  --> https://bugs.webkit.org/attachment.cgi?id=392165
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392165&action=review

r=me, but please wait till <https://webkit.org/b/208453> is landed as current
ToT still uses some of these icons

> Source/WebInspectorUI/ChangeLog:83
> +	   * UserInterface/Images/Function.svg: Removed.

This is still used by `WI.ThreadTreeElement`.

> Source/WebInspectorUI/ChangeLog:89
> +	   * UserInterface/Images/HeapSnapshotSelected.svg: Removed.

This is still used by `WI.HeapAllocationsTimelineOverviewGraph`.

> Source/WebInspectorUI/ChangeLog:98
> +	   * UserInterface/Images/NavigationItemNetworkOverride.svg:

This isn't in this patch.

> Source/WebInspectorUI/ChangeLog:117
> +	   * UserInterface/Images/Thread.svg: Removed.

This is still used by `WI.ThreadTreeElement`.

> Source/WebInspectorUI/ChangeLog:137
> +	   * UserInterface/Images/TypeObject.svg: Removed.

This is still used by `WI.SourcesNavigationSidebarPanel`.