[webkit-reviews] review granted: [Bug 208463] Annotate editable elements with paint order : [Attachment 392179] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 2 14:21:31 PST 2020


Wenson Hsieh <wenson_hsieh at apple.com> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 208463: Annotate editable elements with paint order
https://bugs.webkit.org/show_bug.cgi?id=208463

Attachment 392179: Patch

https://bugs.webkit.org/attachment.cgi?id=392179&action=review




--- Comment #5 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 392179
  --> https://bugs.webkit.org/attachment.cgi?id=392179
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392179&action=review

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:6834
> +	   context.paintOrder = count++;

Nit: IMO, "hitTestingOrder" would be a more relevant name, since this index is
directly influenced by the order of elements as they are hit-tested (which, in
turn, depends on their painting order).


More information about the webkit-reviews mailing list