[webkit-reviews] review denied: [Bug 208420] Web Inspector: introduce a proxy-based protocol test harness : [Attachment 392080] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 2 11:33:50 PST 2020


Devin Rousso <drousso at apple.com> has denied Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 208420: Web Inspector: introduce a proxy-based protocol test harness
https://bugs.webkit.org/show_bug.cgi?id=208420

Attachment 392080: Patch

https://bugs.webkit.org/attachment.cgi?id=392080&action=review




--- Comment #2 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 392080
  --> https://bugs.webkit.org/attachment.cgi?id=392080
Patch

r-, I _really_ don't like this approach.  It now means that code is no longer
searchable.  Most (if not all) IDEs will be unable to "Jump to Definition". 
Why is this needed?  Personally, I don't think the code is any more readable
than it was before (and I didn't have a problem before).


More information about the webkit-reviews mailing list