[webkit-reviews] review granted: [Bug 204955] Implement canvas remote rendering : [Attachment 392140] Patch for review

[bugzilla-daemon at webkit.org]

Jon Lee <jonlee at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 204955: Implement canvas remote rendering
https://bugs.webkit.org/show_bug.cgi?id=204955

Attachment 392140: Patch  for review

https://bugs.webkit.org/attachment.cgi?id=392140&action=review




--- Comment #86 from Jon Lee <jonlee at apple.com> ---
Comment on attachment 392140
  --> https://bugs.webkit.org/attachment.cgi?id=392140
Patch  for review

View in context: https://bugs.webkit.org/attachment.cgi?id=392140&action=review

> Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferMessageHandler.h:58
> +    // Blockers

I find this comment a little odd; I'd rather have the nature of the function be
explicitly in the name.

> Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferMessageHandler.h:59
> +    void ensureBackendCreated();

In a followup patch:
waitForBackendToBeCreated
waitForBackendCreation

> Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackend.h:67
> +    // Blockers

Please remove.