[webkit-reviews] review granted: [Bug 208352] Page::editableElementsInRect() should find nested editable elements and return found elements in paint order : [Attachment 392107] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 208352: Page::editableElementsInRect() should find nested editable elements
and return found elements in paint order
https://bugs.webkit.org/show_bug.cgi?id=208352

Attachment 392107: Patch

https://bugs.webkit.org/attachment.cgi?id=392107&action=review




--- Comment #12 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 392107
  --> https://bugs.webkit.org/attachment.cgi?id=392107
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392107&action=review

> Source/WebCore/page/Page.cpp:930
> +    auto* frameView = mainFrame().view();

auto frameView = makeRefPtr(mainFrame().view());

We generally ref local variables like this in new code (especially in this
case, since the hit-testing code below will trigger layout).

> Source/WebCore/page/Page.cpp:934
> +    auto* document = mainFrame().document();

Ditto.