[webkit-reviews] review granted: [Bug 208322] Improve some media code : [Attachment 392068] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Darin Adler
<darin at apple.com>'s request for review:
Bug 208322: Improve some media code
https://bugs.webkit.org/show_bug.cgi?id=208322

Attachment 392068: Patch

https://bugs.webkit.org/attachment.cgi?id=392068&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 392068
  --> https://bugs.webkit.org/attachment.cgi?id=392068
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392068&action=review

r=me except one problem.

> Source/WebCore/html/track/WebVTTParser.cpp:342
> +		   m_regionList.remove(i);

This is a O(n^2) algorithm that mutates the collection while iterating, so it
would miss regions right after the removed region.  removeAllMatching would be
faster and more correct.