[webkit-reviews] review granted: [Bug 208442] [GTK][WPE] Fix current time and duration formatting in media controls : [Attachment 392128] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 208442: [GTK][WPE] Fix current time and duration formatting in media
controls
https://bugs.webkit.org/show_bug.cgi?id=208442

Attachment 392128: Patch

https://bugs.webkit.org/attachment.cgi?id=392128&action=review




--- Comment #2 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 392128
  --> https://bugs.webkit.org/attachment.cgi?id=392128
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392128&action=review

> Source/WebCore/Modules/mediacontrols/mediaControlsAdwaita.js:411
> +	   else if (duration < 10 * 60) /* Ten minutes */
> +	       this.timeDigitsCount = 3;

I personally dislike having this on a time display. I would strongly recommend
you remove this or run it thru more people who can give an opinion on this.