[webkit-reviews] review granted: [Bug 208266] Optimize Path::encode on platforms that support CGPathGetNumberOfElements : [Attachment 392072] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 208266: Optimize Path::encode on platforms that support
CGPathGetNumberOfElements
https://bugs.webkit.org/show_bug.cgi?id=208266

Attachment 392072: Patch

https://bugs.webkit.org/attachment.cgi?id=392072&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 392072
  --> https://bugs.webkit.org/attachment.cgi?id=392072
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392072&action=review

Do you know the reason for the mysterious Windows failure? It does seem to be
new to the patch.

> Source/WebCore/platform/graphics/Path.h:136
> +    WEBCORE_EXPORT unsigned elementCount() const;

32-bit here

> Source/WebCore/platform/graphics/Path.h:234
> +    encoder << static_cast<uint64_t>(elementCount());

64-bit here

Why?