[webkit-reviews] review granted: [Bug 213771] [Cocoa] [GTK] RunLoop::Timer::isActive() is incorrect for timers while they are firing : [Attachment 403223] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Geoffrey Garen <ggaren at apple.com>'s
request for review:
Bug 213771: [Cocoa] [GTK] RunLoop::Timer::isActive() is incorrect for timers
while they are firing
https://bugs.webkit.org/show_bug.cgi?id=213771

Attachment 403223: Patch

https://bugs.webkit.org/attachment.cgi?id=403223&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 403223
  --> https://bugs.webkit.org/attachment.cgi?id=403223
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403223&action=review

> Source/WTF/wtf/cf/RunLoopCF.cpp:95
> +    if (!CFRunLoopTimerDoesRepeat(cfTimer))
> +	   timer->stop();
> +
>      timer->fired();

Could we have put this code inside TimerBase::fired instead? Or does it not
have an efficient way to check if the timer is non-repeating?

If stop() would do the trick on GLib too that would be neat.