[webkit-reviews] review granted: [Bug 213714] Make NetworkSendQueue use CString instead of String for UTF-8 data : [Attachment 403186] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 213714: Make NetworkSendQueue use CString instead of String for UTF-8 data
https://bugs.webkit.org/show_bug.cgi?id=213714

Attachment 403186: Patch

https://bugs.webkit.org/attachment.cgi?id=403186&action=review




--- Comment #8 from Darin Adler <darin at apple.com> ---
Comment on attachment 403186
  --> https://bugs.webkit.org/attachment.cgi?id=403186
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403186&action=review

r=me assuming Windows failures are not due to these changes

> Source/WebCore/fileapi/NetworkSendQueue.h:49
> +    using WriteString = Function<void(const CString& /* utf8 */)>;

Could use an argument name. It does not need to be commented out. Also, in a
comment I would spell it UTF-8, not utf8.

> Source/WebCore/fileapi/NetworkSendQueue.h:56
> +    void enqueue(CString&& /* utf8 */);

Ditto.