[webkit-reviews] review granted: [Bug 213659] [iOS] Editable regions causes ~1% slowdown in PLT5 : [Attachment 403122] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 213659: [iOS] Editable regions causes ~1% slowdown in PLT5
https://bugs.webkit.org/show_bug.cgi?id=213659

Attachment 403122: Patch

https://bugs.webkit.org/attachment.cgi?id=403122&action=review




--- Comment #26 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 403122
  --> https://bugs.webkit.org/attachment.cgi?id=403122
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403122&action=review

> Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm:142
> +    // If we didn't see an editable region then we don't know whether or not
there are
> +    // editable elements in the rect. We only know that the web process did
not do an
> +    // event region paint to find them. The caller will have to ask the web
process to
> +    // know for sure.
> +    return !sawAnEditableRegion;

Rather than this long-winded comment, you could return an Optional<bool>