[webkit-reviews] review granted: [Bug 213766] Remove WTF::MD5 : [Attachment 403156] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 30 04:56:18 PDT 2020


youenn fablet <youennf at gmail.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 213766: Remove WTF::MD5
https://bugs.webkit.org/show_bug.cgi?id=213766

Attachment 403156: Patch

https://bugs.webkit.org/attachment.cgi?id=403156&action=review




--- Comment #5 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 403156
  --> https://bugs.webkit.org/attachment.cgi?id=403156
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403156&action=review

> Source/WebCore/platform/network/curl/CurlCacheEntry.cpp:223
>	   baseNameBuilder.append(hex(rawdata[i], Lowercase));

This might break existing network cache. I think that is fine.
If not, I guess CURL port can add back MD5 in CURL specific files.


More information about the webkit-reviews mailing list