[webkit-reviews] review granted: [Bug 213556] JavaScript cannot be injected into iframes : [Attachment 403128] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 213556: JavaScript cannot be injected into iframes
https://bugs.webkit.org/show_bug.cgi?id=213556

Attachment 403128: Patch

https://bugs.webkit.org/attachment.cgi?id=403128&action=review




--- Comment #9 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 403128
  --> https://bugs.webkit.org/attachment.cgi?id=403128
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403128&action=review

r=me

> Source/WebKit/UIProcess/API/Cocoa/WKError.mm:77
> +    case WKErrorJavaScriptMissingFrameTarget:

Let's call this WKErrorJavaScriptInvalidFrameTarget since "invalid" is the word
you used in headerdoc.

> Source/WebKit/UIProcess/API/Cocoa/WKError.mm:78
> +	   return WEB_UI_STRING("JavaScript execution was targetted at a frame
that can no longer be targetted", "WKErrorJavaScriptMissingFrameTarget
description");

targetted => targeted

But also, maybe we can be clearer: JavaScript execution targeted an invalid
frame.

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.h:237
> + Passing `nil` for the frame argument is equivalent to passing in a value
representing the main frame of the WKWebView.

=> Pass nil to target the main frame.

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.h:287
> + Passing `nil` for the frame argument is equivalent to passing in a value
representing the main frame of the WKWebView.

=> Pass nil to target the main frame.