[webkit-reviews] review granted: [Bug 213720] Support MediaRecorder.onstart : [Attachment 403052] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 213720: Support MediaRecorder.onstart
https://bugs.webkit.org/show_bug.cgi?id=213720

Attachment 403052: Patch

https://bugs.webkit.org/attachment.cgi?id=403052&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 403052
  --> https://bugs.webkit.org/attachment.cgi?id=403052
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403052&action=review

> Source/WebCore/Modules/mediarecorder/MediaRecorder.cpp:129
> +ExceptionOr<void> MediaRecorder::startRecording(Optional<unsigned>
timeSlice)

It’s not really great to change the type here, but then store the value in
m_timeSlice, an Optional<int>. Basically it’s the same incorrect conversion of
large values to negative numbers, just done at a slightly later time.