[webkit-reviews] review granted: [Bug 213657] On load from back/forward cache, call checkCompleted() for ALL frames inside FrameLoader::commitProvisionalLoad() : [Attachment 402894] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 213657: On load from back/forward cache, call checkCompleted() for ALL
frames inside FrameLoader::commitProvisionalLoad()
https://bugs.webkit.org/show_bug.cgi?id=213657

Attachment 402894: Patch

https://bugs.webkit.org/attachment.cgi?id=402894&action=review




--- Comment #4 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 402894
  --> https://bugs.webkit.org/attachment.cgi?id=402894
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402894&action=review

> Source/WebCore/loader/FrameLoader.cpp:-2080
> -	   checkCompleted();

Is there a potential change of behavior in case checkCompleted done here would
have changed the list of children iframes below?

> Source/WebCore/loader/FrameLoader.cpp:2082
> +	   for (Frame* child = m_frame.tree().firstChild(); child; child =
child->tree().traverseNext(&m_frame))

auto*