[webkit-reviews] review canceled: [Bug 213659] [iOS] Editable regions causes ~1% slowdown in PLT5 : [Attachment 403015] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has canceled Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 213659: [iOS] Editable regions causes ~1% slowdown in PLT5
https://bugs.webkit.org/show_bug.cgi?id=213659

Attachment 403015: Patch

https://bugs.webkit.org/attachment.cgi?id=403015&action=review




--- Comment #16 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 403015
  --> https://bugs.webkit.org/attachment.cgi?id=403015
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403015&action=review

> Source/WebCore/page/SettingsBase.cpp:324
> +#if ENABLE(EDITABLE_REGION)
> +    if (m_page && !m_page->isEditableRegionEnabled() &&
m_page->settings().visibleDebugOverlayRegions() & EditableElementRegion)
> +	   m_page->setEditableRegionEnabled(true);
> +#endif
> +}

r-; this is not good enough: the setting will not ensure editable regions are
still enabled between page loads. I may just remove this change handler....