[webkit-reviews] review granted: [Bug 213658] Video spills over PiP screen a little when using Picture in Picture : [Attachment 402932] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Peng Liu
<peng.liu6 at apple.com>'s request for review:
Bug 213658: Video spills over PiP screen a little when using Picture in Picture
https://bugs.webkit.org/show_bug.cgi?id=213658

Attachment 402932: Patch

https://bugs.webkit.org/attachment.cgi?id=402932&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 402932
  --> https://bugs.webkit.org/attachment.cgi?id=402932
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402932&action=review

> Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm:986
> +    FloatSize videoDimensions = FloatSize(videoElement.videoWidth(),
videoElement.videoHeight());
> +
> +    dispatch_async(dispatch_get_main_queue(), [protectedThis =
makeRefPtr(this), this, videoElementClientRect, videoDimensions, viewRef, mode,
allowsPictureInPicture] {

Can you use something like this instead - FloatSize videoDimensions = {
videoElement.videoWidth(), videoElement.videoHeight() }