[webkit-reviews] review granted: [Bug 153121] window.location.replace with invalid URL should throw : [Attachment 403002] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Rob Buis <rbuis at igalia.com>'s request
for review:
Bug 153121: window.location.replace with invalid URL should throw
https://bugs.webkit.org/show_bug.cgi?id=153121

Attachment 403002: Patch

https://bugs.webkit.org/attachment.cgi?id=403002&action=review




--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 403002
  --> https://bugs.webkit.org/attachment.cgi?id=403002
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403002&action=review

> Source/WebCore/page/Location.cpp:232
> +    if (completedURL.isNull() || !completedURL.isValid())

I wonder if null URLs can ever be valid. If not, then the isNull check is not
needed.