[webkit-reviews] review granted: [Bug 213701] [iOS] Clean up visible position comparisons in WebPage::requestDocumentEditingContext() : [Attachment 403003] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 213701: [iOS] Clean up visible position comparisons in
WebPage::requestDocumentEditingContext()
https://bugs.webkit.org/show_bug.cgi?id=213701

Attachment 403003: Patch

https://bugs.webkit.org/attachment.cgi?id=403003&action=review




--- Comment #3 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 403003
  --> https://bugs.webkit.org/attachment.cgi?id=403003
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403003&action=review

r=me

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:4183
> +	   startOfRangeOfInterestInSelection =
std::max<VisiblePosition>(rangeOfInterestStart, selectionStart);
> +	   endOfRangeOfInterestInSelection =
std::min<VisiblePosition>(rangeOfInterestEnd, selectionEnd);

No need to specify <VisiblePosition> when both arguments are <VisiblePosition>.