[webkit-reviews] review granted: [Bug 213674] Rename initializeThreading to initialize : [Attachment 402939] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Geoffrey Garen <ggaren at apple.com>'s
request for review:
Bug 213674: Rename initializeThreading to initialize
https://bugs.webkit.org/show_bug.cgi?id=213674

Attachment 402939: Patch

https://bugs.webkit.org/attachment.cgi?id=402939&action=review




--- Comment #2 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 402939
  --> https://bugs.webkit.org/attachment.cgi?id=402939
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402939&action=review

r=me

> Source/WTF/ChangeLog:16
> +	   initializeThreading() is a superset. (The opposite is true). I think

I think the parenthesis around "The opposite is true" are not necessary.

> Source/WTF/ChangeLog:17
> +	   this is probably because âthreadingâ can be read as "all threadingâ.

Please fix the non-ascii characters.

> Source/WebCore/bindings/js/ScriptController.cpp:85
> +// FIXME: Remove this function because it's a no-op.

Can you elaborate more on why this comment is true?  I see that this is only
called from commonVMSlow() and DatabaseManager::openDatabase().  How do we
guarantee that JSC::initialize() and WTF::initializeMainThread() will always be
called already before anyone calls commonVM()?