[webkit-reviews] review granted: [Bug 213646] [GTK][WPE] Fix the matching of an empty value in getCgroupControllerPath() when only cgroupsV2 hierarchy is found : [Attachment 402865] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 26 13:00:56 PDT 2020


Adrian Perez <aperez at igalia.com> has granted Pablo Saavedra
<psaavedra at igalia.com>'s request for review:
Bug 213646: [GTK][WPE] Fix the matching of an empty value in
getCgroupControllerPath() when only cgroupsV2 hierarchy is found
https://bugs.webkit.org/show_bug.cgi?id=213646

Attachment 402865: patch

https://bugs.webkit.org/attachment.cgi?id=402865&action=review




--- Comment #2 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 402865
  --> https://bugs.webkit.org/attachment.cgi?id=402865
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402865&action=review

> Source/WebKit/UIProcess/linux/MemoryPressureMonitor.cpp:220
> +	       // cgroupv2

You can remove this comment because the comparisong with
the CGROUP_V2_HIERARCHY constant in the line right above
is self-explanatory—which is why we like using constants
with meaningful names, of course :)


More information about the webkit-reviews mailing list