[webkit-reviews] review denied: [Bug 213625] [iOS] Network process is crashing when launching TJMaxx app due to invalid NetworkProcess::DestroySession IPC message : [Attachment 402835] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 26 09:42:32 PDT 2020


Alex Christensen <achristensen at apple.com> has denied Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 213625: [iOS] Network process is crashing when launching TJMaxx app due to
invalid NetworkProcess::DestroySession IPC message
https://bugs.webkit.org/show_bug.cgi?id=213625

Attachment 402835: Patch

https://bugs.webkit.org/attachment.cgi?id=402835&action=review




--- Comment #9 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 402835
  --> https://bugs.webkit.org/attachment.cgi?id=402835
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402835&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:124
> +    if (!(self = [super init]))

Why don't we just call _initWithConfiguration with a non-persistent
configuration instead of all this mess?


More information about the webkit-reviews mailing list