[webkit-reviews] review granted: [Bug 202233] MediaRecorder.start() Method is Ignoring the "timeslice" Parameter : [Attachment 402801] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 202233: MediaRecorder.start() Method is Ignoring the "timeslice" Parameter
https://bugs.webkit.org/show_bug.cgi?id=202233

Attachment 402801: Patch

https://bugs.webkit.org/attachment.cgi?id=402801&action=review




--- Comment #8 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 402801
  --> https://bugs.webkit.org/attachment.cgi?id=402801
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402801&action=review

> Source/WebCore/Modules/mediarecorder/MediaRecorder.cpp:129
> +ExceptionOr<void> MediaRecorder::startRecording(Optional<int> timeSlice)

`timeSlice` is `optional unsigned long` in the spec. Does it matter that this
uses a signed int?