[webkit-reviews] review granted: [Bug 213626] REGRESSION(r256166, r260596) WKNavigationAction.request.allHTTPHeaderFields needs to contain User-Agent and Accept : [Attachment 402826] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 25 16:55:38 PDT 2020


Darin Adler <darin at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 213626: REGRESSION(r256166, r260596)
WKNavigationAction.request.allHTTPHeaderFields needs to contain User-Agent and
Accept
https://bugs.webkit.org/show_bug.cgi?id=213626

Attachment 402826: Patch

https://bugs.webkit.org/attachment.cgi?id=402826&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 402826
  --> https://bugs.webkit.org/attachment.cgi?id=402826
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402826&action=review

> Source/WebCore/ChangeLog:10
> +	   Those two revisions seemed to just subtly move things around, but
they caused API-breaking changes that caused real problems.
> +	   This effectively reverts the parts of those changes that caused the
breakages.

The revisions were not supposed to move things around. They were supposed to
remove unnecessary things.

Seems now that for the Cocoa API they were necessary things. Would be nice if
there was a way to restore that behavior without affecting things other than
the Cocoa API.


More information about the webkit-reviews mailing list