[webkit-reviews] review denied: [Bug 213616] Non unified build fixes, midsummer 2020 edition : [Attachment 402814] Patch for landing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 25 15:15:16 PDT 2020


Mark Lam <mark.lam at apple.com> has denied  review:
Bug 213616: Non unified build fixes, midsummer 2020 edition
https://bugs.webkit.org/show_bug.cgi?id=213616

Attachment 402814: Patch for landing

https://bugs.webkit.org/attachment.cgi?id=402814&action=review




--- Comment #5 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 402814
  --> https://bugs.webkit.org/attachment.cgi?id=402814
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=402814&action=review

> Source/JavaScriptCore/b3/air/AirTmpWidth.h:31
> +#include "AirTmpInlines.h"

We should never #include an Inlines.h in a .h.	This is the wrong way to fix
this issue.


More information about the webkit-reviews mailing list