[webkit-reviews] review granted: [Bug 213333] Text manipulation should observe adjacent elements with new renderer together : [Attachment 402511] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 213333: Text manipulation should observe adjacent elements with new
renderer together
https://bugs.webkit.org/show_bug.cgi?id=213333

Attachment 402511: Patch

https://bugs.webkit.org/attachment.cgi?id=402511&action=review




--- Comment #12 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 402511
  --> https://bugs.webkit.org/attachment.cgi?id=402511
Patch

r=me

I slightly prefer the rare data solution, since I like it when you don't have
to worry about doing interesting pointer safety things in your destructor.
Also, you only pay the memory cost when you use the feature, which won't happen
on most pages.

That said, I think this approach works, and resolves all review comments so
far. We can always discuss the rare data approach more when we have a chance,
and reconsider it.