[webkit-reviews] review granted: [Bug 213578] Adding Experimental Feature Flags for CoreImage backed SVG/CSS Filters : [Attachment 402715] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 25 10:05:45 PDT 2020


Darin Adler <darin at apple.com> has granted guowei_yang at apple.com's request for
review:
Bug 213578: Adding Experimental Feature Flags for CoreImage backed SVG/CSS
Filters
https://bugs.webkit.org/show_bug.cgi?id=213578

Attachment 402715: Patch

https://bugs.webkit.org/attachment.cgi?id=402715&action=review




--- Comment #9 from Darin Adler <darin at apple.com> ---
Comment on attachment 402715
  --> https://bugs.webkit.org/attachment.cgi?id=402715
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402715&action=review

Looks OK

> Source/WTF/wtf/PlatformUse.h:63
> +#if PLATFORM(COCOA)
> +#define USE_CORE_IMAGE 1
> +#endif

There’s already CoreImage usage in WebKit. I’m not sure how we’re going to use
this going forward, and if maybe we should be using it on existing code instead
of what it’s currently doing?


More information about the webkit-reviews mailing list