[webkit-reviews] review granted: [Bug 213596] [GTK][WPE] Add webkit_authentication_request_get_security_origin : [Attachment 402727] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at gnome.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 213596: [GTK][WPE] Add webkit_authentication_request_get_security_origin
https://bugs.webkit.org/show_bug.cgi?id=213596

Attachment 402727: Patch

https://bugs.webkit.org/attachment.cgi?id=402727&action=review




--- Comment #3 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 402727
  --> https://bugs.webkit.org/attachment.cgi?id=402727
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402727&action=review

> Source/WebKit/UIProcess/API/glib/WebKitAuthenticationRequest.cpp:368
> +    return webkitSecurityOriginCreate(SecurityOrigin::create(protocol,
protectionSpace.host(), protectionSpace.port()));

You could ASSERT(!protocol.isEmpty()) here, just in case.
webkitSecurityOriginCreate really will allow creating an invalid
WebKitSecurityOrigin with empty protocol.

> Source/WebKit/UIProcess/API/gtk/WebKitAuthenticationRequest.h:30
>  #include <webkit2/WebKitCredential.h>
> +#include <webkit2/WebKitSecurityOrigin.h>
>  #include <webkit2/WebKitDefines.h>

It's misalphabetized.