[webkit-reviews] review granted: [Bug 213587] [Intl] Disprefer using ICU enums directly as instance variables : [Attachment 402707] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 213587: [Intl] Disprefer using ICU enums directly as instance variables
https://bugs.webkit.org/show_bug.cgi?id=213587

Attachment 402707: Patch

https://bugs.webkit.org/attachment.cgi?id=402707&action=review




--- Comment #3 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 402707
  --> https://bugs.webkit.org/attachment.cgi?id=402707
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402707&action=review

r=me

> Source/JavaScriptCore/runtime/IntlPluralRules.h:83
> +    bool m_isOrdinal { false };

I think `enum class OrdinalType : uint8_t { Ordinal, Cardinal };` would be
better.