[webkit-reviews] review denied: [Bug 213455] Web Inspector: Add support for timezone override in the Page agent : [Attachment 402631] Patch

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has denied Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 213455: Web Inspector: Add support for timezone override in the Page agent
https://bugs.webkit.org/show_bug.cgi?id=213455

Attachment 402631: Patch

https://bugs.webkit.org/attachment.cgi?id=402631&action=review




--- Comment #8 from Brian Burg <bburg at apple.com> ---
Comment on attachment 402631
  --> https://bugs.webkit.org/attachment.cgi?id=402631
Patch

If this enhancement isn't exposed in Web Inspector user interface, why is it
being added to Web Inspector Protocol?

Given that this enhancement doesn't have to do with debugging and inspection,
it seems like something more suitable as a WebDriver extension capability
(webkit:timezone or similar) or extension command.

I'm not sure whether arbitrarily overriding the timezone after a page has
loaded makes sense–for example, cookie expiration would not be affected by this
change as it exists currently. It will also not line up with time data that the
embeddng application provides via other interfaces, such as extensions.