[webkit-reviews] review granted: [Bug 213568] Allow the async clipboard API to write data when copying via menu action or key binding : [Attachment 402684] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 213568: Allow the async clipboard API to write data when copying via menu
action or key binding
https://bugs.webkit.org/show_bug.cgi?id=213568

Attachment 402684: Patch

https://bugs.webkit.org/attachment.cgi?id=402684&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 402684
  --> https://bugs.webkit.org/attachment.cgi?id=402684
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402684&action=review

> Source/WebCore/Modules/async-clipboard/Clipboard.cpp:53
> +    if (settings.javaScriptCanAccessClipboard() ||
frame.editor().isCopyingFromMenuOrKeyBinding())

Is it always right to ask this Frame’s editor? Should we instead ask the main
frame’s editor?