[webkit-reviews] review granted: [Bug 213570] Black rectangle appears when closing PIP on iPhone : [Attachment 402678] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Peng Liu
<peng.liu6 at apple.com>'s request for review:
Bug 213570: Black rectangle appears when closing PIP on iPhone
https://bugs.webkit.org/show_bug.cgi?id=213570

Attachment 402678: Patch

https://bugs.webkit.org/attachment.cgi?id=402678&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 402678
  --> https://bugs.webkit.org/attachment.cgi?id=402678
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402678&action=review

> Source/WebCore/ChangeLog:10
> +	   Don't unhide the window and view of WebAVPlayerViewController before
exiting Picture-in-Picture.

I think it is worth saying where m_window will be made visible, e.g. "...
before exiting Picture-in-Picture because m_window will be shown ..."