[webkit-reviews] review denied: [Bug 213534] [WinCairo] Cannot build without resource load statistics : [Attachment 402594] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Stephan Szabo
<stephan.szabo at sony.com>'s request for review:
Bug 213534: [WinCairo] Cannot build without resource load statistics
https://bugs.webkit.org/show_bug.cgi?id=213534

Attachment 402594: Patch

https://bugs.webkit.org/attachment.cgi?id=402594&action=review




--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 402594
  --> https://bugs.webkit.org/attachment.cgi?id=402594
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402594&action=review

> Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.cpp:75
> +#if ENABLE(RESOURCE_LOAD_STATISTICS)

WKWebsiteDataStoreRemoveITPDataForDomain should probably just do nothing or
immediately call the callback if RESOURCE_LOAD_STATISTICS is not enabled,
because there's nothing to do.

> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:1013
> +#if ENABLE(RESOURCE_LOAD_STATISTICS)

Ditto.	I think it's ok to just do nothing here if RESOURCE_LOAD_STATISTICS is
not enabled.