[webkit-reviews] review granted: [Bug 213543] Null Ptr Deref READ @ WTF::Optional<WTF::Seconds>::clear : [Attachment 402625] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Pinki Gyanchandani
<pgyanchandani at apple.com>'s request for review:
Bug 213543: Null Ptr Deref READ @ WTF::Optional<WTF::Seconds>::clear
https://bugs.webkit.org/show_bug.cgi?id=213543

Attachment 402625: Patch

https://bugs.webkit.org/attachment.cgi?id=402625&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 402625
  --> https://bugs.webkit.org/attachment.cgi?id=402625
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402625&action=review

Null check looks fine.

>
LayoutTests/fast/rendering/iframe-window-animation-modifies-iframe-srcdoc-crash
.html:22
> +<video  onloadstart="runTest()">

This is running after DumpRenderTree has already finished the test.  If you
move the testRunner.dumpAsText call to outside the function it should make the
results the same for DumpRenderTree and WebKitTestRunner.