[webkit-reviews] review granted: [Bug 213565] REGRESSION(r262341) Use UTF-8 to decode CFURLRefs from IPC : [Attachment 402660] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 213565: REGRESSION(r262341) Use UTF-8 to decode CFURLRefs from IPC
https://bugs.webkit.org/show_bug.cgi?id=213565

Attachment 402660: Patch

https://bugs.webkit.org/attachment.cgi?id=402660&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 402660
  --> https://bugs.webkit.org/attachment.cgi?id=402660
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402660&action=review

r=me but please do improve the test coverage

>> LayoutTests/fast/url/navigate-non-ascii.html:2
>> +location.assign('//\u2000');
> 
> Can we have a test in TestWTF too? The reason is that it is possible that we
add URL validation check in `location.assign` since it is specified in the
spec.
> https://html.spec.whatwg.org/multipage/history.html#dom-location-assign
> "Parse url relative to the entry settings object. If that failed, throw a
"SyntaxError" DOMException."
> 
> If it is added, this test becomes one which does not stress ArgumentCodersCF.

I agree that we need a more durable test that will exercise the code path even
if we fix location assignment.

Not as sure as Yusuke that a test written in C++ in TestWTF is the best option.
Are there other ways to exercise this?