[webkit-reviews] review granted: [Bug 213431] Migrate run-minibrowser to webkitpy : [Attachment 402472] Patch

[bugzilla-daemon at webkit.org]

Jonathan Bedard <jbedard at apple.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 213431: Migrate run-minibrowser to webkitpy
https://bugs.webkit.org/show_bug.cgi?id=213431

Attachment 402472: Patch

https://bugs.webkit.org/attachment.cgi?id=402472&action=review




--- Comment #12 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 402472
  --> https://bugs.webkit.org/attachment.cgi?id=402472
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402472&action=review

> Tools/Scripts/webkitpy/minibrowser/run_webkit_app.py:30
> +    option_parser = argparse.ArgumentParser(prog="run-minibrowser",
usage="%(prog)s [options] [url]", add_help=False)

Let's add a FIXME here.

Ultimately, I think that this function should accept an optional name of the
binary being run, which would actually change what we feed to argparse. That
way, we can replace some other scripts (like run-safari) with Python versions
that share code.

> Tools/Scripts/webkitpy/port/wpe.py:143
> +	   command = [miniBrowser, ]

Shouldn't need the trailing ,