[webkit-reviews] review requested: [Bug 204457] Math.max() can yield the wrong result for max(0, -0). : [Attachment 402636] Math.{max, min} fixes, v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 24 05:01:02 PDT 2020


Xan Lopez <xan.lopez at gmail.com> has asked  for review:
Bug 204457: Math.max() can yield the wrong result for max(0, -0).
https://bugs.webkit.org/show_bug.cgi?id=204457

Attachment 402636: Math.{max,min} fixes, v2

https://bugs.webkit.org/attachment.cgi?id=402636&action=review




--- Comment #17 from Xan Lopez <xan.lopez at gmail.com> ---
Created attachment 402636

  --> https://bugs.webkit.org/attachment.cgi?id=402636&action=review

Math.{max,min} fixes, v2

Added requested comments and links to the spec, testmasm tests. Gave another
shot at the style issue and still seems to me the code (both new and existing)
is following the guide, so we should probably either tweak the script or change
the whole file accordingly.


More information about the webkit-reviews mailing list