[webkit-reviews] review granted: [Bug 212392] Use ObjectIdentifier<> instead of uint64_t for context IDs in VideoFullscreenManagerProxy : [Attachment 402620] Patch v1

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 212392: Use ObjectIdentifier<> instead of uint64_t for context IDs in
VideoFullscreenManagerProxy
https://bugs.webkit.org/show_bug.cgi?id=212392

Attachment 402620: Patch v1

https://bugs.webkit.org/attachment.cgi?id=402620&action=review




--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 402620
  --> https://bugs.webkit.org/attachment.cgi?id=402620
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=402620&action=review

> Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.mm:371
>      MESSAGE_CHECK_CONTEXTID(contextId);

We can remove this one.

> Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.mm:504
>      MESSAGE_CHECK_CONTEXTID(contextId);

Ditto here and above.

> Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:512
>      MESSAGE_CHECK_CONTEXTID(contextId);

Do we need to remove this one as well? Ditto below.

> Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:513
>      MESSAGE_CHECK(videoLayerID);

Should we also use ObjectIdentifier for videoLayerID in the future?