[webkit-reviews] review granted: [Bug 213531] Web Inspector: add a tooltip to the icon of overridden resources to clarify meaning : [Attachment 402589] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 23 15:43:52 PDT 2020
Brian Burg <bburg at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 213531: Web Inspector: add a tooltip to the icon of overridden resources to
clarify meaning
https://bugs.webkit.org/show_bug.cgi?id=213531
Attachment 402589: Patch
https://bugs.webkit.org/attachment.cgi?id=402589&action=review
--- Comment #2 from Brian Burg <bburg at apple.com> ---
Comment on attachment 402589
--> https://bugs.webkit.org/attachment.cgi?id=402589
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=402589&action=review
r=me
> Source/WebInspectorUI/ChangeLog:30
> + Add a `title` to the overriden resource icon that clarifies the fact
that the resource was
Nit: overridden
> Source/WebInspectorUI/UserInterface/Views/DataGridNode.js:410
> + // Subclasses may override
Nit: trailing period
More information about the webkit-reviews
mailing list