[webkit-reviews] review granted: [Bug 213523] Removed unrestricted keyword from attributes in PannerNode : [Attachment 402593] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Clark Wang <clark_wang at apple.com>'s
request for review:
Bug 213523: Removed unrestricted keyword from attributes in PannerNode
https://bugs.webkit.org/show_bug.cgi?id=213523

Attachment 402593: Patch

https://bugs.webkit.org/attachment.cgi?id=402593&action=review




--- Comment #12 from Darin Adler <darin at apple.com> ---
Comment on attachment 402593
  --> https://bugs.webkit.org/attachment.cgi?id=402593
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402593&action=review

> Source/WebCore/Modules/webaudio/PannerNode.cpp:257
> +	   rolloffFactor = clampTo(rolloffFactor, 0.0, 1.0);

Since we already checked for negative, we don’t really need clamp here. Could
just use std::min(rolloffFactor, 1.0).