[webkit-reviews] review granted: [Bug 213523] Removed unrestricted keyword from attributes in PannerNode : [Attachment 402578] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Clark Wang <clark_wang at apple.com>'s
request for review:
Bug 213523: Removed unrestricted keyword from attributes in PannerNode
https://bugs.webkit.org/show_bug.cgi?id=213523

Attachment 402578: Patch

https://bugs.webkit.org/attachment.cgi?id=402578&action=review




--- Comment #7 from Darin Adler <darin at apple.com> ---
Comment on attachment 402578
  --> https://bugs.webkit.org/attachment.cgi?id=402578
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402578&action=review

> Source/WebCore/Modules/webaudio/PannerNode.idl:42
> +    [MayThrowException] attribute double refDistance;
> +    [MayThrowException] attribute double maxDistance;
> +    [MayThrowException] attribute double rolloffFactor;

I’m surprised that the correct attribute here is MayThrowException. I would
have expected SetterMayThrowException. It’s possible I am just remembering
wrong.

> Source/WebCore/Modules/webaudio/PannerNode.idl:47
> +    [MayThrowException] attribute double coneOuterGain;

Ditto.

> LayoutTests/ChangeLog:13
> +	   * webaudio/pannernode-basic-expected.txt:
> +	   * webaudio/pannernode-basic.html:
> +	   * webaudio/unprefixed-pannernode-basic-expected.txt: Copied from
LayoutTests/webaudio/pannernode-basic-expected.txt.
> +	   * webaudio/unprefixed-pannernode-basic.html: Copied from
LayoutTests/webaudio/pannernode-basic.html.

Seems like the prefixed version is the one that should have the longer name.