[webkit-reviews] review granted: [Bug 213525] [JSC] Clobberize misses `write(World)` report in some nodes : [Attachment 402576] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 23 11:53:30 PDT 2020


Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 213525: [JSC] Clobberize misses `write(World)` report in some nodes
https://bugs.webkit.org/show_bug.cgi?id=213525

Attachment 402576: Patch

https://bugs.webkit.org/attachment.cgi?id=402576&action=review




--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 402576
  --> https://bugs.webkit.org/attachment.cgi?id=402576
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402576&action=review

r=me

> Source/JavaScriptCore/ChangeLog:3
> +	   [JSC] Clobberize misses `write(World)` report in some nodes

write(Heap).

> Source/JavaScriptCore/ChangeLog:9
> +	   In some DFG nodes, clobberize phase misses `clobberTopFunctor` call
while it is `write(World)`,

You mean `write(Heap)`, right?


More information about the webkit-reviews mailing list