[webkit-reviews] review granted: [Bug 213423] [Apple Pay] WebPaymentCoordinatorProxy can be destroyed without dismissing its authorization presenter : [Attachment 402392] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 23 06:32:33 PDT 2020


youenn fablet <youennf at gmail.com> has granted Andy Estes <aestes at apple.com>'s
request for review:
Bug 213423: [Apple Pay] WebPaymentCoordinatorProxy can be destroyed without
dismissing its authorization presenter
https://bugs.webkit.org/show_bug.cgi?id=213423

Attachment 402392: Patch

https://bugs.webkit.org/attachment.cgi?id=402392&action=review




--- Comment #5 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 402392
  --> https://bugs.webkit.org/attachment.cgi?id=402392
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402392&action=review

> Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.cpp:318
> +	  
send(Messages::WebPaymentCoordinator::DidCancelPaymentSession(WTFMove(error)));

No need for WTFMove, DidCancelPaymentSession is probably taking a const&


More information about the webkit-reviews mailing list