[webkit-reviews] review granted: [Bug 213509] [WebXR] Fix PlatformXR initialization/destruction : [Attachment 402545] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 213509: [WebXR] Fix PlatformXR initialization/destruction
https://bugs.webkit.org/show_bug.cgi?id=213509

Attachment 402545: Patch

https://bugs.webkit.org/attachment.cgi?id=402545&action=review




--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 402545
  --> https://bugs.webkit.org/attachment.cgi?id=402545
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402545&action=review

> Source/WebCore/platform/xr/openxr/PlatformXROpenXR.cpp:218
>	       s_instance->m_impl = makeUnique<Impl>();

Can we do this assignment in Instance constructor?
And make m_impl a UniqueRef<> maybe?