[webkit-reviews] review granted: [Bug 213411] Web Inspector: do not report data on the rejected intercepted CORS request : [Attachment 402339] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 22 17:46:04 PDT 2020


Devin Rousso <drousso at apple.com> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 213411: Web Inspector: do not report data on the rejected intercepted CORS
request
https://bugs.webkit.org/show_bug.cgi?id=213411

Attachment 402339: Patch

https://bugs.webkit.org/attachment.cgi?id=402339&action=review




--- Comment #2 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 402339
  --> https://bugs.webkit.org/attachment.cgi?id=402339
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402339&action=review

r=me

> Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp:1295
> +	       return;

Style: please add a newline after this `return`

> LayoutTests/http/tests/inspector/network/intercept-cors-request.html:12
> +	   let response = await fetch("http://localhost:8000/data", { mode:
"cors" });

Style: no space after `{` or before `}` when inlined

> LayoutTests/http/tests/inspector/network/intercept-cors-request.html:15
> +	   return { error: e.message };

Ditto (:12)

> LayoutTests/http/tests/inspector/network/intercept-cors-request.html:21
> +    InspectorTest.debug();

oops

> LayoutTests/http/tests/inspector/network/intercept-cors-request.html:58
> +	   name: "Network.interceptRequestWithResponse.CORS allow origin",

NIT: we usually don't use spaces in test case names, preferring camel casing
and periods.
```
    name: "Network.interceptRequestWithResponse.CORS.Origin.Allow",
```

> LayoutTests/http/tests/inspector/network/intercept-cors-request.html:66
> +	   name: "Network.interceptRequestWithResponse.CORS disallow origin",

Ditto (:58)
```
    name: "Network.interceptRequestWithResponse.CORS.Origin.Disallow",
```


More information about the webkit-reviews mailing list