[webkit-reviews] review granted: [Bug 213435] AXIsolatedTree::generateSubtree should properly assign the generated subtree to its parent node. : [Attachment 402494] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Andres Gonzalez
<andresg_22 at apple.com>'s request for review:
Bug 213435: AXIsolatedTree::generateSubtree should properly assign the
generated subtree to its parent node.
https://bugs.webkit.org/show_bug.cgi?id=213435

Attachment 402494: Patch

https://bugs.webkit.org/attachment.cgi?id=402494&action=review




--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 402494
  --> https://bugs.webkit.org/attachment.cgi?id=402494
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402494&action=review

r=me assuming all the tests pass

> Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h:101
> +    AXIsolatedTreeID m_treeID;

Typically we put all the function members before any of the data members. This
could go back where it was before, or if the order of data members matters, at
least down after the functions.

> Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h:128
> +    // Called on main thread to updates both m_nodeMap and
m_pendingChildrenUpdates.
> +    void updateChildrenIDs(AXID axID, Vector<AXID>&& childrenIDs);

"updates" -> "update"

Typically we put all the function members before any of the data members, so
this could go above m_axObjectCache.