[webkit-reviews] review canceled: [Bug 213242] Web Inspector: Add setScreenSizeOverride API to the Page agent : [Attachment 402454] Patch

[bugzilla-daemon at webkit.org]

Philippe Normand <pnormand at igalia.com> has canceled Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 213242: Web Inspector: Add setScreenSizeOverride API to the Page agent
https://bugs.webkit.org/show_bug.cgi?id=213242

Attachment 402454: Patch

https://bugs.webkit.org/attachment.cgi?id=402454&action=review




--- Comment #17 from Philippe Normand <pnormand at igalia.com> ---
Comment on attachment 402454
  --> https://bugs.webkit.org/attachment.cgi?id=402454
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402454&action=review

>> Source/WebCore/css/MediaQueryEvaluator.cpp:391
>> +	auto size = frame.page()->screenSize();
> 
> What guarantees page is not null here?

Good point. This needs to be revisited indeed.