[webkit-reviews] review granted: [Bug 209900] [WPE][GTK] Public API should not allow trying to register a special URI scheme : [Attachment 402391] Patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has granted Michael Catanzaro
<mcatanzaro at gnome.org>'s request for review:
Bug 209900: [WPE][GTK] Public API should not allow trying to register a special
URI scheme
https://bugs.webkit.org/show_bug.cgi?id=209900

Attachment 402391: Patch

https://bugs.webkit.org/attachment.cgi?id=402391&action=review




--- Comment #13 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 402391
  --> https://bugs.webkit.org/attachment.cgi?id=402391
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402391&action=review

> Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp:1280
> +	   g_critical("Cannot register invalid URI scheme %s", scheme);

I would probably write this as:

   auto isValidScheme = !!WTF::URLParser::maybeCanonicalizeScheme(scheme);
   g_return_if_fail(iValidScheme);

So the error message follows the usual format emitted by the
g_return[_val]_if_fail()
macros.