[webkit-reviews] review granted: [Bug 213450] [WTF] URL should support dataLog : [Attachment 402441] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 213450: [WTF] URL should support dataLog
https://bugs.webkit.org/show_bug.cgi?id=213450

Attachment 402441: Patch

https://bugs.webkit.org/attachment.cgi?id=402441&action=review




--- Comment #5 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 402441
  --> https://bugs.webkit.org/attachment.cgi?id=402441
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402441&action=review

r=me with nit.

> Source/WTF/wtf/URL.cpp:770
> +void URL::dump(PrintStream& out) const
> +{
> +    out.print(m_string);
> +}

nit: should we keep this definition in the header instead?  If it's not
normally used and we only need this for occasional debugging use, then it is
more efficient to have it in the header vs explicitly putting it here.	There a
lot of other less commonly dumped data structures that do this also.