[webkit-reviews] review granted: [Bug 213351] [ Catalina Debug WK2 ] fast/events/platform-wheelevent-in-scrolling-div.html is a flaky failure : [Attachment 402434] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jun 21 17:53:23 PDT 2020


Wenson Hsieh <wenson_hsieh at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 213351: [ Catalina Debug WK2 ]
fast/events/platform-wheelevent-in-scrolling-div.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=213351

Attachment 402434: Patch

https://bugs.webkit.org/attachment.cgi?id=402434&action=review




--- Comment #8 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 402434
  --> https://bugs.webkit.org/attachment.cgi?id=402434
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402434&action=review

> LayoutTests/fast/events/platform-wheelevent-in-scrolling-div.html:28
> +		   eventSender.callAfterScrollingCompletes(() => {
> +		       checkOffsets();
> +		   });

Nit - I think this would read better as
`eventSender.callAfterScrollingCompletes(checkOffsets);`


More information about the webkit-reviews mailing list